From: "Kirill A. Shutemov" <k.shutemov@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [BUG] [PATCH] Syscall gethostname fix
Date: Wed, 7 Mar 2007 13:17:14 +0200 [thread overview]
Message-ID: <20070307111714.GC18623@localhost.localdomain> (raw)
In-Reply-To: <20070228141347.GA4618@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On [Wed, 28.02.2007 17:13], Kirill A. Shutemov wrote:
> Patch in the attachment.
addrlen bytes should be allocated, not target_addrlen. It's typo I think.
> diff --git a/qemu/linux-user/syscall.c b/qemu/linux-user/syscall.c
> index f3f97b0..ccb0e52 100644
> --- a/qemu/linux-user/syscall.c
> +++ b/qemu/linux-user/syscall.c
> @@ -875,7 +875,7 @@ static long do_getsockname(int fd, target_ulong target_addr,
> target_ulong target_addrlen)
> {
> socklen_t addrlen = tget32(target_addrlen);
> - void *addr = alloca(target_addrlen);
> + void *addr = alloca(addrlen);
> long ret;
>
> ret = get_errno(getsockname(fd, addr, &addrlen));
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-03-07 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 14:13 [Qemu-devel] [BUG] [PATCH] Syscall gethostname fix Kirill A. Shutemov
2007-03-07 11:17 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307111714.GC18623@localhost.localdomain \
--to=k.shutemov@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).