From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, sol10x86@cox.net
Subject: Re: [Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu
Date: Tue, 13 Mar 2007 14:57:51 +0000 [thread overview]
Message-ID: <200703131457.51938.paul@codesourcery.com> (raw)
In-Reply-To: <18872536.1173795944190.JavaMail.root@eastrmwml08.mgt.cox.net>
> However, it's very wax-on, wax-off kind of thing. Without the patch,
> arm-test and mips-test crash. With the patch, I can run both tests.
As I've said before it's not sufficient to say that a patch fixes a bug, you
have to explain *what* bug you are fixing, *how* it fixes the bug, and *why*
it's the correct way to fix it. In order to review the patch I need to be
able to follow your logic for creating the patch. If you don't understand the
patch you should not be submitting it.
In this specific case:
* What: "qemu crashes" is not a particularly useful description of the failure
mode. I want to know how (eg. segfault, abort, infinite loop, does wrong
thing) it crashes, which bit of code it's executing when it crashes, and how
it got to that point.
* How: I'm also not convinced your #ifdef does what you think it does, though
It's somewhat unclear what you're trying to achieve. I'm guessing you
intended to disable the code on sparc hosted arm+mips targets
* Why: "I randomly changed things until it started working" is not a valid
justification for a change. Why doesn't this failure occur on other hosts?
Why only arm and mips targets?
Paul
next prev parent reply other threads:[~2007-03-13 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 14:25 [Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu Ben Taylor
2007-03-13 14:57 ` Paul Brook [this message]
2007-03-15 16:22 ` Rob Landley
-- strict thread matches above, loose matches on Subject: below --
2007-03-15 16:50 Ben Taylor
2007-03-13 14:01 Ben Taylor
2007-03-13 14:08 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703131457.51938.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=sol10x86@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).