From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HR8Sb-0006ZA-Ts for qemu-devel@nongnu.org; Tue, 13 Mar 2007 10:58:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HR8Sa-0006Yi-BQ for qemu-devel@nongnu.org; Tue, 13 Mar 2007 10:58:45 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HR8Sa-0006Ye-5t for qemu-devel@nongnu.org; Tue, 13 Mar 2007 09:58:44 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HR8Rn-0003BZ-0w for qemu-devel@nongnu.org; Tue, 13 Mar 2007 10:57:55 -0400 From: Paul Brook Subject: Re: [Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu Date: Tue, 13 Mar 2007 14:57:51 +0000 References: <18872536.1173795944190.JavaMail.root@eastrmwml08.mgt.cox.net> In-Reply-To: <18872536.1173795944190.JavaMail.root@eastrmwml08.mgt.cox.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703131457.51938.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, sol10x86@cox.net > However, it's very wax-on, wax-off kind of thing. Without the patch, > arm-test and mips-test crash. With the patch, I can run both tests. As I've said before it's not sufficient to say that a patch fixes a bug, you have to explain *what* bug you are fixing, *how* it fixes the bug, and *why* it's the correct way to fix it. In order to review the patch I need to be able to follow your logic for creating the patch. If you don't understand the patch you should not be submitting it. In this specific case: * What: "qemu crashes" is not a particularly useful description of the failure mode. I want to know how (eg. segfault, abort, infinite loop, does wrong thing) it crashes, which bit of code it's executing when it crashes, and how it got to that point. * How: I'm also not convinced your #ifdef does what you think it does, though It's somewhat unclear what you're trying to achieve. I'm guessing you intended to disable the code on sparc hosted arm+mips targets * Why: "I randomly changed things until it started working" is not a valid justification for a change. Why doesn't this failure occur on other hosts? Why only arm and mips targets? Paul