From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HSJTr-0001pY-BC for qemu-devel@nongnu.org; Fri, 16 Mar 2007 16:56:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HSJTo-0001oe-MR for qemu-devel@nongnu.org; Fri, 16 Mar 2007 16:56:54 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HSJTo-0001o1-FT for qemu-devel@nongnu.org; Fri, 16 Mar 2007 15:56:52 -0500 Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HSJSe-00075s-Jp for qemu-devel@nongnu.org; Fri, 16 Mar 2007 16:55:40 -0400 From: Julian Seward Subject: Re: [Qemu-devel] [PATCH] Reducing X communication bandwidth, take 2 Date: Fri, 16 Mar 2007 20:53:02 +0000 References: <200703140152.01319.jseward@acm.org> <45FAE490.6090809@codemonkey.ws> In-Reply-To: <45FAE490.6090809@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703162053.02198.jseward@acm.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Friday 16 March 2007 18:40, Anthony Liguori wrote: > Hi Julian, > > Julian Seward wrote: > > Here is a somewhat revised version of a patch I first made nearly > > three years ago. The original thread is > > > > http://lists.gnu.org/archive/html/qemu-devel/2004-07/msg00263.html > > > > It still uses a shadow frame buffer. Fabrice mentioned this is not > > necessary > > I thought about this a little and here's what I came up with. > > I think we could change vga_draw_line* so that as part of the drawing > process, it compared the newly generated pixel with the previous pixel > value and returned back the min, max x-coordinate that changed. > > Since we tend to only extend the vertical dirty range by a couple > pixels, this should be a relatively cheap way of reducing the size of > the update region. Sounds plausible - having said that, I have no familiarity with the VGA code. Also sounds like a cleaner solution than mine. Is there something which guarantees that the vertical dirty range only overshoots by some small number of pixels? (thinking more about it .. it doesn't matter - finding min/max that changed for each line will also make it possible to identify the vertical limits of the change). Will this work also for the CL542x adaptor? (Does that fall in the category of vga?) My current hack works for with/without -std-vga and I think that's because it lives "underneath" both, in the connection to SDL. J