qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, balrogg@gmail.com
Subject: Re: [Qemu-devel] [PATCH] SecureDigital card emulation.
Date: Sat, 17 Mar 2007 10:29:18 +0000	[thread overview]
Message-ID: <200703171029.19713.paul@codesourcery.com> (raw)
In-Reply-To: <fb249edb0703161359n53c71ba4k76b209783a05a5cd@mail.gmail.com>

On Friday 16 March 2007 20:59, andrzej zaborowski wrote:
> Emulates an SD card with the full command set (no SPI mode though).
> Should be more or less compliant with version 1.10 specification.

I suspect your code only works on x86. Specifically things like:

> +struct sd_response_r1_s {
> +    uint8_t cmd;
> +    uint32_t status;
> +    uint8_t crc;
> +};

Will be a 12-byte struct on many hosts, and probably also breaks on big-endian 
hosts. AFAICS there's no way for the caller of sd_write_cmdline to figure out 
what type of response is returned (other than the length), so has to rely on 
doing a bitwise copy.

Paul

  reply	other threads:[~2007-03-17 10:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 20:59 [Qemu-devel] [PATCH] SecureDigital card emulation andrzej zaborowski
2007-03-17 10:29 ` Paul Brook [this message]
2007-03-17 11:01   ` andrzej zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703171029.19713.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=balrogg@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).