From: Thiemo Seufer <ths@networkno.de>
To: ????????? <cywang.eda@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] scsi patch
Date: Mon, 19 Mar 2007 12:42:11 +0000 [thread overview]
Message-ID: <20070319124211.GD7744@networkno.de> (raw)
In-Reply-To: <a20f395e0703140815q3c7a5608l6bc2d282c75e09a7@mail.gmail.com>
????????? wrote:
> --- ../../tmp/qemu-0.9.0/hw/lsi53c895a.c 2007-02-06 07:01:
> 54.000000000 +0800
> +++ lsi53c895a.c 2007-03-08 20:50:03.094098835 +0800
> @@ -251,7 +251,7 @@
> uint32_t ia;
> uint32_t sbc;
> uint32_t csbc;
> - uint32_t scratch[13]; /* SCRATCHA-SCRATCHR */
> + uint32_t scratch[18]; /* SCRATCHA-SCRATCHR */
This still looks inconsistent. SCRATCHR suggests 18 available
registers, but the code below handles only 17 scratch registers.
Could you check what's the right thing there?
Otherwise the patch looks good.
Thiemo
next prev parent reply other threads:[~2007-03-19 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-10 14:03 [Qemu-devel] scsi patch 王成業
2007-03-11 4:27 ` 王成業
2007-03-14 15:15 ` 王成業
2007-03-19 12:42 ` Thiemo Seufer [this message]
2007-03-19 14:37 ` Wang Cheng Yeh
-- strict thread matches above, loose matches on Subject: below --
2007-04-25 5:48 Wang Cheng Yeh
2007-04-26 19:26 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070319124211.GD7744@networkno.de \
--to=ths@networkno.de \
--cc=cywang.eda@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).