From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HTK2T-0004DJ-V9 for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:44:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HTK2S-0004Cc-2M for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:44:49 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HTK2R-0004CZ-TN for qemu-devel@nongnu.org; Mon, 19 Mar 2007 10:44:47 -0500 Received: from partizan.velesys.com ([213.184.230.195]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HTK0y-0006MR-BD for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:43:16 -0400 Received: from localhost (partizan [10.0.0.24]) by partizan.velesys.com (paritzan.velesys.com) with ESMTP id 8616DD64D25 for ; Mon, 19 Mar 2007 17:45:37 +0200 (EET) Received: from partizan.velesys.com ([10.0.0.24]) by localhost (partizan.velesys.com [10.0.0.24]) (amavisd-new, port 10024) with ESMTP id wHaZaLMOCcmV for ; Mon, 19 Mar 2007 17:45:34 +0200 (EET) Received: from localhost.localdomain (xps.velesys.com [10.0.0.92]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by partizan.velesys.com (paritzan.velesys.com) with ESMTP id 32A12D64CF5 for ; Mon, 19 Mar 2007 17:45:34 +0200 (EET) Date: Mon, 19 Mar 2007 17:25:26 +0200 From: "Kirill A. Shutemov" Subject: Re: [Qemu-devel] [PATCH] EABI fcntl on x86_64 Message-ID: <20070319152526.GA22236@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On [Mon, 19.03.2007 11:30], Stuart Anderson wrote: >=20 > When running ARM EABI binaries on x86_64, the target_eabi_flock64 > structure is already padded correct so the padding is not needed. > > This patch adds an #ifdef to only include the _pad member on 32-but > hosts. Are you sure that problem is in padding? Please, look at my patch=20 in post "[PATCH] fcntl64 fix". >=20 >=20 > Stuart >=20 > Stuart R. Anderson anderson@netsweng.com > Network & Software Engineering http://www.netsweng.com/ > 1024D/37A79149: 0791 D3B8 9A4C 2CDC A31F > BD03 0A62 E534 37A7 9149 Content-Description: fcntl fix > Index: linux-user/syscall_defs.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /sources/qemu/qemu/linux-user/syscall_defs.h,v > retrieving revision 1.30 > diff -u -r1.30 syscall_defs.h > --- linux-user/syscall_defs.h 22 Oct 2006 00:18:54 -0000 1.30 > +++ linux-user/syscall_defs.h 19 Mar 2007 15:25:58 -0000 > @@ -1409,7 +1409,9 @@ > struct target_eabi_flock64 { > short l_type; > short l_whence; > +#if HOST_LONG_BITS =3D=3D 32 > int __pad; > +#endif > unsigned long long l_start; > unsigned long long l_len; > int l_pid; --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFF/qt9bWYnhzC5v6oRAiA9AJsFgti7WkF9D/HAwI6w/BTLKbNXfACeJHwY oH8HDbeMH+sbX1EEYb16Aqw= =JShk -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--