From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Stuart Anderson <anderson@netsweng.com>
Subject: Re: [Qemu-devel] [PATCH] EABI fcntl on x86_64
Date: Mon, 19 Mar 2007 15:38:50 +0000 [thread overview]
Message-ID: <200703191538.51607.paul@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703191126160.12505@trantor.stuart.netsweng.com>
On Monday 19 March 2007 15:30, Stuart Anderson wrote:
> When running ARM EABI binaries on x86_64, the target_eabi_flock64
> structure is already padded correct so the padding is not needed.
> This patch adds an #ifdef to only include the _pad member on 32-but
> hosts.
This is wrong. The struct is packed, so its layout should be independent of
the host. How did you test your change?
Paul
next prev parent reply other threads:[~2007-03-19 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 15:30 [Qemu-devel] [PATCH] EABI fcntl on x86_64 Stuart Anderson
2007-03-19 15:25 ` Kirill A. Shutemov
2007-03-19 15:38 ` Paul Brook [this message]
2007-03-19 15:57 ` Stuart Anderson
2007-03-19 16:16 ` Stuart Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703191538.51607.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=anderson@netsweng.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).