From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HTJyI-0001ig-2n for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:40:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HTJyG-0001eF-KN for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:40:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HTJyG-0001dx-Gl for qemu-devel@nongnu.org; Mon, 19 Mar 2007 10:40:28 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HTJwn-0005GD-4v for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:38:57 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] EABI fcntl on x86_64 Date: Mon, 19 Mar 2007 15:38:50 +0000 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703191538.51607.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stuart Anderson On Monday 19 March 2007 15:30, Stuart Anderson wrote: > When running ARM EABI binaries on x86_64, the target_eabi_flock64 > structure is already padded correct so the padding is not needed. > This patch adds an #ifdef to only include the _pad member on 32-but > hosts. This is wrong. The struct is packed, so its layout should be independent of the host. How did you test your change? Paul