From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HTm5z-0001U0-LW
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 17:42:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HTm5y-0001TB-5L
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 17:42:19 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HTm5y-0001T7-19
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 16:42:18 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1HTm4L-0005Gk-PU
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 17:40:38 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] fcntl64 fix
Date: Tue, 20 Mar 2007 21:40:30 +0000
References: <20070309215335.GB5629@localhost.localdomain>
	<Pine.LNX.4.64.0703201625070.12505@trantor.stuart.netsweng.com>
	<Pine.LNX.4.64.0703201713390.12505@trantor.stuart.netsweng.com>
In-Reply-To: <Pine.LNX.4.64.0703201713390.12505@trantor.stuart.netsweng.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200703202140.31353.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Stuart Anderson <anderson@netsweng.com>

>  struct target_eabi_flock64 {
>  	short  l_type;
>  	short  l_whence;
> +#if HOST_LONG_BITS == 32
>          int __pad;
> +#endif

This change is definitely wrong. This is a target structure, and is packed, so 
should be independent of the host.

Paul