From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HTnan-0003Qe-Ap for qemu-devel@nongnu.org; Tue, 20 Mar 2007 19:18:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HTnal-0003QQ-QV for qemu-devel@nongnu.org; Tue, 20 Mar 2007 19:18:12 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HTnal-0003QN-Mx for qemu-devel@nongnu.org; Tue, 20 Mar 2007 18:18:11 -0500 Received: from partizan.velesys.com ([213.184.230.195]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HTnZ8-0006oC-QO for qemu-devel@nongnu.org; Tue, 20 Mar 2007 19:16:31 -0400 Received: from localhost (partizan [10.0.0.24]) by partizan.velesys.com (paritzan.velesys.com) with ESMTP id 3A12AD65882 for ; Wed, 21 Mar 2007 01:19:04 +0200 (EET) Received: from partizan.velesys.com ([10.0.0.24]) by localhost (partizan.velesys.com [10.0.0.24]) (amavisd-new, port 10024) with ESMTP id xXHLwiVmDk9e for ; Wed, 21 Mar 2007 01:19:02 +0200 (EET) Received: from localhost.localdomain (mm-185-159-57-86.adsl.mgts.by [86.57.159.185]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by partizan.velesys.com (paritzan.velesys.com) with ESMTP id 56000D6587E for ; Wed, 21 Mar 2007 01:19:01 +0200 (EET) Date: Wed, 21 Mar 2007 00:56:17 +0200 From: "Kirill A. Shutemov" Subject: Re: [Qemu-devel] [PATCH] fcntl64 fix Message-ID: <20070320225617.GA32229@localhost.localdomain> References: <20070320114315.GA26019@localhost.localdomain> <20070320135910.GA18571@localhost.localdomain> <20070320171103.GA20530@localhost.localdomain> <20070320193442.GA11933@localhost.localdomain> <20070320214749.GE2311@networkno.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <20070320214749.GE2311@networkno.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On [Tue, 20.03.2007 21:47], Thiemo Seufer wrote: > Stuart Anderson wrote: > [snip] > > --- linux-user/syscall_defs.h.orig 2007-02-23 15:44:47.000000000 -0500 > > +++ linux-user/syscall_defs.h 2007-02-23 15:44:26.000000000 -0500 > > @@ -1414,7 +1414,9 @@ > > struct target_eabi_flock64 { > > short l_type; > > short l_whence; > > +#if HOST_LONG_BITS =3D=3D 32 > > int __pad; > > +#endif >=20 > Still, this part makes no sense to me since it is in a packed struct. > Can you explain why this works better for you? Primarily, I also thought that problem is in padding, because, without the patch F_GETLK, on 32-bit target recognises as F_GETLK64 on 64-bit host. It's happen because on 64-bit host and 32-bit target F_GETLK =3D=3D F_GETLK64 = =3D=3D=20 TARGET_F_GETLK. So if you're using qemu-arm on 64-bit host and target eabi= =20 program calls fcntl(fd,F_GETLK,...), target_eabi_flock64 will be used by=20 mistake. Disabling padding can helps in some trivial cases to pass=20 pseudo-correct args to fcntl. Stuart, am I right? --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + Velesys LLC, http://www.velesys.com/ + ALT Linux Team, http://www.altlinux.com/ --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFGAGaobWYnhzC5v6oRAi8sAJ9G9WRpbyjqrcRtkmLWKOjaehYZMACfTgLn VH8C1G3I6zg3Uy/5XayI4ws= =X8FF -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--