From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Stuart Anderson <anderson@netsweng.com>
Subject: Re: [Qemu-devel] [PATCH] fcntl64 fix
Date: Tue, 20 Mar 2007 23:43:35 +0000 [thread overview]
Message-ID: <200703202343.36216.paul@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703201852120.12505@trantor.stuart.netsweng.com>
> Now that the dust has settled, I see where the change is probably a
> no-op anyway. A quick little test program indicates that on x86_64,
> l_start will have an offset of 8 wether the structure is packed or not,
> and wether the __pad member is present or not. The unsigned long long is
> always going to be aligned to a 8 byte boundary.
The __pad member is essential. Your logic is wrong is two ways:
a) The struct is packed. This overrides normal alignment and ensures the
structure contains no padding.
b) long long has whatever alignment the host feels like giving it. There's no
guarantee it's going to be 8 byte aligned.
Paul
next prev parent reply other threads:[~2007-03-20 23:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 21:53 [Qemu-devel] [PATCH] fcntl64 fix Kirill A. Shutemov
2007-03-19 17:13 ` Thiemo Seufer
2007-03-19 17:48 ` Stuart Anderson
2007-03-20 6:46 ` Stuart Anderson
2007-03-20 11:43 ` Kirill A. Shutemov
[not found] ` <Pine.LNX.4.64.0703200954000.12505@trantor.stuart.netsweng.com>
2007-03-20 13:59 ` Kirill A. Shutemov
2007-03-20 16:54 ` Stuart Anderson
2007-03-20 17:11 ` Kirill A. Shutemov
2007-03-20 18:03 ` Stuart Anderson
2007-03-20 19:34 ` Kirill A. Shutemov
2007-03-20 20:26 ` Stuart Anderson
2007-03-20 21:32 ` Stuart Anderson
2007-03-20 21:40 ` Paul Brook
2007-03-20 21:47 ` Thiemo Seufer
2007-03-20 22:56 ` Kirill A. Shutemov
2007-03-20 22:59 ` Kirill A. Shutemov
2007-03-21 13:49 ` Stuart Anderson
2007-03-20 23:05 ` Stuart Anderson
2007-03-20 23:10 ` Kirill A. Shutemov
2007-03-20 23:11 ` Kirill A. Shutemov
2007-03-20 23:43 ` Paul Brook [this message]
2007-03-21 13:50 ` Stuart Anderson
2007-03-22 14:23 ` Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2007-03-09 21:48 Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703202343.36216.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=anderson@netsweng.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).