From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HXjC3-0005EN-Bu
	for qemu-devel@nongnu.org; Sat, 31 Mar 2007 15:24:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HXjC1-00053y-8i
	for qemu-devel@nongnu.org; Sat, 31 Mar 2007 15:24:54 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HXjC1-00052s-3i
	for qemu-devel@nongnu.org; Sat, 31 Mar 2007 14:24:53 -0500
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1HXj9A-0000Gv-EQ
	for qemu-devel@nongnu.org; Sat, 31 Mar 2007 15:21:56 -0400
Date: Sat, 31 Mar 2007 20:21:04 +0100
Subject: Re: [Qemu-devel] [PATCH] clone syscall fix
Message-ID: <20070331192104.GC24690@networkno.de>
References: <Pine.LNX.4.64.0703292140020.514@trantor.stuart.netsweng.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0703292140020.514@trantor.stuart.netsweng.com>
From: Thiemo Seufer <ths@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Anderson <anderson@netsweng.com>
Cc: qemu-devel@nongnu.org

Stuart Anderson wrote:
> 
> Even though clone() and fork() are related, they don't seem to be close
> enough to allow a single routine to be used to implement both. With this
> patch, the LTP tests for clone now pass.

But it still does the same, assuming VM_CLONE is set, except for passing
additional arguments to the host call. Passing untranslated regs looks
like a bug to me, I'm unsure about the tls_val.

> It may be possible to fold this back into do_fork(), but this just seemed to
> be a little bit more straightforward.

Since Linux's fork() is just a specialcase of clone() this should be
done eventually.


Thiemo