From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HYO43-0002bl-Sy
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 11:03:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HYO41-0002ac-R7
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 11:03:23 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HYO41-0002aY-KO
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 11:03:21 -0400
Received: from vc4-2-0-87.dsl.netrack.net ([199.45.160.85]
	helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <imp@bsdimp.com>) id 1HYO0y-0001qn-6z
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 11:00:12 -0400
Date: Mon, 02 Apr 2007 08:58:51 -0600 (MDT)
Message-Id: <20070402.085851.796899796.imp@bsdimp.com>
Subject: Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20070402124122.GE24846@networkno.de>
References: <200704021025.l32APPUX024888@imap.tools.intra>
	<20070402124122.GE24846@networkno.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, ths@networkno.de

In message: <20070402124122.GE24846@networkno.de>
            Thiemo Seufer <ths@networkno.de> writes:
: I made that "#ifdef _BSD" based on the assumption it is ok for all
: BSD variants, including Darwin.

_BSD isn't defined on all variants of BSD.  sys/param.h defines BSD to
be 199506 on all BSD systems (at least all of them derived from 4.4BSD
lite).  sys/param.h also defines BSD4_3 and BSD4_4.  FreeBSD defines
__FreeBSD__ in the compiler, NetBSD defined __NetBSD__, OpenBSD
defines __OpenBSD__.  I'm unsure what darwin/osx define.

so unless I missed a change elsewhere in the build system to define
_BSD, this change needs some more thought.

Warner