qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Keil <jk@tools.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD
Date: Mon, 2 Apr 2007 12:25:23 +0200 (CEST)	[thread overview]
Message-ID: <200704021025.l32APPUX024888@imap.tools.intra> (raw)


> From: Thiemo Seufer <ths@networkno.de>
> Todd T. Fries wrote:
> > This is relative to the 20070319 snapshot.
> > 
> > 
> > --- dyngen-exec.h.orig	Mon Feb  5 17:01:54 2007
> > +++ dyngen-exec.h	Sat Mar 10 16:39:39 2007
...
> >  /* XXX: This may be wrong for 64-bit ILP32 hosts.  */
> >  typedef void * host_reg_t;
> > @@ -78,11 +83,15 @@ typedef void * host_reg_t;
> >  #define UINT32_MAX		(4294967295U)
> >  #define UINT64_MAX		((uint64_t)(18446744073709551615))
> >  
> > +#ifdef __OpenBSD__
> > +typedef struct __sFILE FILE;
> > +#else
> >  typedef struct FILE FILE;
> >  extern int fprintf(FILE *, const char *, ...);
> >  extern int printf(const char *, ...);
> >  #undef NULL
> >  #define NULL 0
> > +#endif
> 
> Shouldn't this cover only the FILE typedef?

Probably.

My dyngen-exec.h has a similar change, when I made some NetBSD experiments:

Index: dyngen-exec.h
===================================================================
RCS file: /cvsroot/qemu/qemu/dyngen-exec.h,v
retrieving revision 1.33
diff -u -B -r1.33 dyngen-exec.h
--- dyngen-exec.h       30 Mar 2007 16:44:53 -0000      1.33
+++ dyngen-exec.h       2 Apr 2007 09:42:03 -0000
@@ -78,7 +78,11 @@
 #define UINT32_MAX             (4294967295U)
 #define UINT64_MAX             ((uint64_t)(18446744073709551615))

+#ifdef __NetBSD__
+typedef struct __sFILE FILE;
+#else
 typedef struct FILE FILE;
+#endif
 extern int fprintf(FILE *, const char *, ...);
 extern int fputs(const char *, FILE *);
 extern int printf(const char *, ...);

             reply	other threads:[~2007-04-02 10:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-02 10:25 Juergen Keil [this message]
2007-04-02 12:41 ` [Qemu-devel] Patch: dyngen-exec.h for OpenBSD Thiemo Seufer
2007-04-02 14:58   ` M. Warner Losh
2007-04-02 16:08     ` Thiemo Seufer
2007-04-02 16:55       ` M. Warner Losh
  -- strict thread matches above, loose matches on Subject: below --
2007-03-21  2:39 Todd T. Fries
2007-04-02  9:54 ` Thiemo Seufer
2007-04-05 22:12   ` Todd T. Fries
2007-04-06 23:21     ` Thiemo Seufer
2007-04-07  0:50     ` Paul Brook
2007-04-07  3:34       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704021025.l32APPUX024888@imap.tools.intra \
    --to=jk@tools.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).