qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, dsilvers@simtec.co.uk
Subject: Re: [Qemu-devel] Simtec BAST emulation
Date: Mon, 2 Apr 2007 18:45:10 +0100	[thread overview]
Message-ID: <200704021845.10852.paul@codesourcery.com> (raw)
In-Reply-To: <1175522199.18271.19.camel@petitemort.i.digital-scurf.org>

On Monday 02 April 2007 14:56, Daniel Silverstone wrote:
> Hi,
>
> Myself and my colleagues have worked hard and produced a new system
> emulation for qemu for the Simtec BAST board.

A few issues with the patch, which I think need to be resolved before it can 
be applied:

- You're using global structures to store machine state.
While it's debatable whether you'll ever have more than one s3c2410, I think 
it's definitely still worth allowing for this possibility, and encapsulating 
the state in a structure, like all the other hardware emulation does.

- For the device emulation (dm9000 and ide, maybe others) you should use 
pic_set_irq_new, instead of passing a separate set_irq function. Other ARM 
boards already support arbitrary routing of interrupts via hw/arm_pic.[ch].

- usb_ohci_mmap_init should look more like (or even be the same function as) 
usb_ohci_init_pxa.

> The emulation is complete enough to start Simtec's ABLE boot loader
> (downloadable from www.simtec.co.uk) and also is capable of being
> direct-booted with a linux kernel/initrd combination as per the
> versatile etc.

What is the licence for ABLE? Would we be able to distribute it with qemu?

Paul

  reply	other threads:[~2007-04-02 17:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-02 13:56 [Qemu-devel] Simtec BAST emulation Daniel Silverstone
2007-04-02 17:45 ` Paul Brook [this message]
2007-04-03 10:12   ` Daniel Silverstone
2007-04-17  9:51   ` Daniel Silverstone
2007-04-17  9:51   ` Daniel Silverstone
2007-04-02 23:04 ` andrzej zaborowski
2007-04-03 10:09   ` Daniel Silverstone
2007-04-03 15:01     ` andrzej zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704021845.10852.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=dsilvers@simtec.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).