From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HZzBv-0002kZ-Gz
	for qemu-devel@nongnu.org; Fri, 06 Apr 2007 20:54:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HZzBt-0002kH-TH
	for qemu-devel@nongnu.org; Fri, 06 Apr 2007 20:54:07 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HZzBt-0002kD-Ov
	for qemu-devel@nongnu.org; Fri, 06 Apr 2007 20:54:05 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1HZz8L-00087Z-O4
	for qemu-devel@nongnu.org; Fri, 06 Apr 2007 20:50:26 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD
Date: Sat, 7 Apr 2007 01:50:20 +0100
References: <20070321023900.GA13604@fries.net>
	<20070402095453.GB24846@networkno.de>
	<20070405221242.GB4559@fries.net>
In-Reply-To: <20070405221242.GB4559@fries.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200704070150.21692.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, todd@fries.net

On Thursday 05 April 2007 23:12, Todd T. Fries wrote:
> Penned by Thiemo Seufer on 20070402 10:54.53, we have:
> | >  /* NOTE: standard headers should be used with special care at this
> | >     point because host CPU registers are used as global variables. So=
me
> | >     host headers do not allow that. */
> | >  #include <stddef.h>
> | > -
> | > +#ifdef __OpenBSD__
> | > +#include <sys/types.h>
> Hello? Portability? =A0sys/types.h defines these types portably.
> Doing so the way this code does it, is not portable.

If you want  portability you should be including stdint.h (or inttypes.h fo=
r=20
old, broken systems).

> Why is it that qemu knows what the definition of these prototypes
> are on all systems without consulting the header files.  I have a
> better idea, lets let the header files define the prototypes.
> Who would have though of that?

See the big NOTE: comment above. dyngen is inherently unportable.

Paul