From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HeA1x-0005qk-9F
	for qemu-devel@nongnu.org; Wed, 18 Apr 2007 09:17:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HeA1u-0005qY-W8
	for qemu-devel@nongnu.org; Wed, 18 Apr 2007 09:17:04 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HeA1u-0005qV-Of
	for qemu-devel@nongnu.org; Wed, 18 Apr 2007 09:17:02 -0400
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1He9x4-0005eS-AL
	for qemu-devel@nongnu.org; Wed, 18 Apr 2007 09:12:02 -0400
Date: Wed, 18 Apr 2007 14:06:53 +0100
Subject: Re: [Qemu-devel] qemu/hw pckbd.c
Message-ID: <20070418130653.GA2879@networkno.de>
References: <E1HdZzG-0007a3-4T@cvs> <1176888568.6333.62.camel@rapid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1176888568.6333.62.camel@rapid>
From: Thiemo Seufer <ths@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "J. Mayer" <l_indien@magic.fr>
Cc: qemu-devel@nongnu.org

J. Mayer wrote:
> On Mon, 2007-04-16 at 22:47 +0000, Thiemo Seufer wrote:
> > CVSROOT:	/sources/qemu
> > Module name:	qemu
> > Changes by:	Thiemo Seufer <ths>	07/04/16 22:47:54
> > 
> > Modified files:
> > 	hw             : pckbd.c 
> > 
> > Log message:
> > 	Support it_shift for mmapped pckbd.
> > 
> > CVSWeb URLs:
> > http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pckbd.c?cvsroot=qemu&r1=1.19&r2=1.20
> 
> Thanks for the update.
> Here's another small patch, based on the same idea of what is done for
> the memory-mapped serial ports and which seems useful to implement some
> targets: it may be needed not to register the I/O memory area in the
> pckbd driver but let the caller do it.
> Please take a look.

Actually, I thought about adding such a feature but then decided to
defer it until it is actually needed. OTOH, with qemu handling mmio
at page granularity it is likely needed sooner or later, so we could
just declare it a standard implementation feature. I am ok with it 
either way.


Thiemo