From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HesjC-0002l6-9n
	for qemu-devel@nongnu.org; Fri, 20 Apr 2007 09:00:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Hesj9-0002kS-Hk
	for qemu-devel@nongnu.org; Fri, 20 Apr 2007 09:00:41 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Hesj7-0002kI-V0
	for qemu-devel@nongnu.org; Fri, 20 Apr 2007 09:00:38 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Hese3-00082q-Hj
	for qemu-devel@nongnu.org; Fri, 20 Apr 2007 08:55:23 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH] x86_64 debug registers for gdb
Date: Fri, 20 Apr 2007 13:55:13 +0100
References: <45105864.9090902@windriver.com>
	<200704191612.00346.paul@codesourcery.com>
	<4627DF73.3030902@web.de>
In-Reply-To: <4627DF73.3030902@web.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200704201355.14379.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>

On Thursday 19 April 2007 22:30, Jan Kiszka wrote:
> + =A0 =A0registers[_GP_REGS+2] =3D env->segs[R_CS].selector;
> + =A0 =A0registers[_GP_REGS+3] =3D env->segs[R_SS].selector;
> + =A0 =A0registers[_GP_REGS+4] =3D env->segs[R_DS].selector;
> + =A0 =A0registers[_GP_REGS+5] =3D env->segs[R_ES].selector;
> + =A0 =A0registers[_GP_REGS+6] =3D env->segs[R_FS].selector;
> + =A0 =A0registers[_GP_REGS+7] =3D env->segs[R_GS].selector;
>
> +    registers[_FPCTL_OFS] =3D env->fpuc;
> + =A0 =A0registers[_FPCTL_OFS+1] =3D fpus;
> + =A0 =A0registers[_FPCTL_OFS+2] =3D 0; /* XXX: convert tags */
> + =A0 =A0registers[_FPCTL_OFS+3] =3D 0; /* fiseg */
> + =A0 =A0registers[_FPCTL_OFS+4] =3D 0; /* fioff */
> + =A0 =A0registers[_FPCTL_OFS+5] =3D 0; /* foseg */
> + =A0 =A0registers[_FPCTL_OFS+6] =3D 0; /* fooff */
> + =A0 =A0registers[_FPCTL_OFS+7] =3D 0; /* fop */
> + =A0 =A0for (i =3D _FPCTL_OFS; i < _FPCTL_OFS+8; i++)
> =A0 =A0 =A0 =A0 =A0tswapls(&registers[i]);

These are all wrong on x86-64.

Paul