qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thiemo Seufer <ths@networkno.de>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu Makefile.target cpu-all.h cpu-exec.c dynge...
Date: Wed, 9 May 2007 01:02:04 +0100	[thread overview]
Message-ID: <20070509000204.GC13638@networkno.de> (raw)
In-Reply-To: <463F8AAE.3030700@mail.berlios.de>

Stefan Weil wrote:
[snip]

I cherrypicked the easy bits, and will look at the rest when I have
more time.

> When I started to write MIPS host, I found it difficult to
> get all locations which needed new code. To make it easier for
> new ports, I changed sequences of #if ... #endif, #if ... #endif
> into #if ... #elif ... #elif ... #else #error #endif.

Some of those folded unrelated things together, I committed a different
patch based on yours.

> Other changes include some smaller spelling corrections.

Also committed.

> Most important was Johannes code for testandset and PARAMn.

AFAICS that testandset implementation is broken, and I think
mine is correct, maybe except for the +R vs. +m bit in the asm
constraints.

Did my implementation fail for you?

> The patch still includes your relocation code, but it is disabled
> and uses my own code. I had no time to check or try the differences.

Then I gather there's no particular reason why my _PC16 reloc code
is deleted in the patch.


Thiemo

  parent reply	other threads:[~2007-05-09  0:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-05 19:23 [Qemu-devel] qemu Makefile.target cpu-all.h cpu-exec.c dynge Thiemo Seufer
2007-05-07 20:23 ` [Qemu-devel] [PATCH] " Stefan Weil
2007-05-07 20:27   ` Stefan Weil
2007-05-07 22:48   ` Johannes Schindelin
2007-05-09  0:02   ` Thiemo Seufer [this message]
2007-07-31 20:49     ` [Qemu-devel] [PATCH] QEMU Mips Host Stefan Weil
2007-05-09  0:17   ` [Qemu-devel] [PATCH] qemu Makefile.target cpu-all.h cpu-exec.c dynge Thiemo Seufer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070509000204.GC13638@networkno.de \
    --to=ths@networkno.de \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).