From: Thiemo Seufer <ths@networkno.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH, MIPS64] dmult & dmultu emulation
Date: Wed, 16 May 2007 13:01:04 +0100 [thread overview]
Message-ID: <20070516120104.GE22169@networkno.de> (raw)
In-Reply-To: <20070516092038.GA15853@amd64.aurel32.net>
Aurelien Jarno wrote:
> On Wed, May 16, 2007 at 02:00:14AM +0200, Aurelien Jarno wrote:
> > On Tue, May 15, 2007 at 10:07:00PM +0100, Paul Brook wrote:
> > > > The patch below fixes the emulation of dmult and dmultu by doing a real
> > > > 64x64 -> 128 multiplication.
> > >
> > > Can we share the implementation between targets please. We already have an
> > > implementation of mul64 in target-i386/helper.c.
> > >
> > > I've no real preference which implementation we use, I just don't want there
> > > to be several of them.
> >
> > Ok, please find an updated patch below. The multiplications functions
> > are in mul64.c and are now shared by the i386 and mips targets.
> >
>
> 03:40 < pbrook> aurel32: I think you've got a sign mismatch in your target-i386/helper.c patch. You've replaced imul64 with mulu64.
>
> I confirm I have made a mistake here, please find an updated patch
> below.
I moved the file to host-utils.c, there may be more such functions
needed some day.
Thiemo
prev parent reply other threads:[~2007-05-16 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 20:49 [Qemu-devel] [PATCH, MIPS64] dmult & dmultu emulation Aurelien Jarno
2007-05-15 21:07 ` Paul Brook
2007-05-16 0:00 ` Aurelien Jarno
[not found] ` <74FC5FD4-034C-11DC-8C22-0005025B95B5@hotmail.com>
2007-05-16 1:26 ` C.W. Betts
2007-05-16 8:38 ` Thiemo Seufer
2007-05-16 9:23 ` Aurelien Jarno
2007-05-16 9:20 ` Aurelien Jarno
2007-05-16 12:01 ` Thiemo Seufer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516120104.GE22169@networkno.de \
--to=ths@networkno.de \
--cc=aurelien@aurel32.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).