From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Hw47N-0004Tc-7V
	for qemu-devel@nongnu.org; Wed, 06 Jun 2007 18:36:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Hw47L-0004Pa-Ie
	for qemu-devel@nongnu.org; Wed, 06 Jun 2007 18:36:40 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Hw47L-0004P5-Bu
	for qemu-devel@nongnu.org; Wed, 06 Jun 2007 18:36:39 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Hw47K-0007US-QD
	for qemu-devel@nongnu.org; Wed, 06 Jun 2007 18:36:39 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Add parallel memory mapped interface
Date: Wed, 6 Jun 2007 23:36:28 +0100
References: <20070606193004.73B7B6F536@smtp4-g19.free.fr>
	<f43fc5580706061314l203d03b5qb969a4a226bfef32@mail.gmail.com>
In-Reply-To: <f43fc5580706061314l203d03b5qb969a4a226bfef32@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200706062336.29722.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, hpoussin@reactos.org

On Wednesday 06 June 2007, Blue Swirl wrote:
> On 6/6/07, Herv=C3=A9 Poussineau <hpoussin@reactos.org> wrote:
> > Hi,
> >
> > This patch adds a memory-mapped interface to the parallel port emulatio=
n.
> > It is not as complete as I/O interface (no EPP/ECP), but I didn't want =
to
> > add lots of code for very little use.
> > It also cleans up indentation of the file (replaces tabulations by four
> > spaces)

IMHO it's a bad idea to combine writespace cleanups with actual changes.
It makes the patch much larger and more confusing than it needs to be.

> Please don't use target_ulong in device drivers, but
> target_phys_addr_t for physical addresses. I don't know about IO
> addresses, uint32_t?

"int" is appropriate for IO port addresses.
This is what the register_ioport_{read,write} routines use.

Paul