[Qemu-devel] qemu/hw pixel_ops.h

[Qemu-devel] qemu/hw pixel_ops.h

[Blue Swirl]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Changes by:	Blue Swirl <blueswir1>	07/06/10 16:35:21

Added files:
	hw             : pixel_ops.h 

Log message:
	 Add hw/pixel_ops.h

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pixel_ops.h?cvsroot=qemu&rev=1.1

Re: [Qemu-devel] qemu/hw pixel_ops.h

[Andreas Färber]

Am 10.06.2007 um 18:35 schrieb Blue Swirl:

> CVSROOT:	/cvsroot/qemu
> Module name:	qemu
> Changes by:	Blue Swirl <blueswir1>	07/06/10 16:35:21
>
> Added files:
> 	hw             : pixel_ops.h
>
> Log message:
> 	 Add hw/pixel_ops.h
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pixel_ops.h? 
> cvsroot=qemu&rev=1.1

Replacing my local files with HEAD I get the following errors:

/Users/andreas/Q/tmp/qemu/hw/vga.c:1317: error:  
`vga_draw_line15_15bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1317: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1317: error: (near initialization  
for `vga_draw_line_table[47]')
/Users/andreas/Q/tmp/qemu/hw/vga.c:1318: error:  
`vga_draw_line15_16bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1318: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1318: error: (near initialization  
for `vga_draw_line_table[48]')
/Users/andreas/Q/tmp/qemu/hw/vga.c:1325: error:  
`vga_draw_line16_15bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1325: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1325: error: (near initialization  
for `vga_draw_line_table[54]')
/Users/andreas/Q/tmp/qemu/hw/vga.c:1326: error:  
`vga_draw_line16_16bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1326: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1326: error: (near initialization  
for `vga_draw_line_table[55]')
/Users/andreas/Q/tmp/qemu/hw/vga.c:1333: error:  
`vga_draw_line24_15bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1333: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1333: error: (near initialization  
for `vga_draw_line_table[61]')
/Users/andreas/Q/tmp/qemu/hw/vga.c:1334: error:  
`vga_draw_line24_16bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1334: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1334: error: (near initialization  
for `vga_draw_line_table[62]')
/Users/andreas/Q/tmp/qemu/hw/vga.c:1341: error:  
`vga_draw_line32_15bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1341: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1341: error: (near initialization  
for `vga_draw_line_table[68]')
/Users/andreas/Q/tmp/qemu/hw/vga.c:1342: error:  
`vga_draw_line32_16bgr' undeclared here (not in a function)
/Users/andreas/Q/tmp/qemu/hw/vga.c:1342: error: initializer element  
is not constant
/Users/andreas/Q/tmp/qemu/hw/vga.c:1342: error: (near initialization  
for `vga_draw_line_table[69]')

Those did not surface when testing the patch...

Re: [Qemu-devel] qemu/hw pixel_ops.h

[Blue Swirl]

On 6/10/07, Andreas Färber <andreas.faerber@web.de> wrote:
> Replacing my local files with HEAD I get the following errors:
>
> /Users/andreas/Q/tmp/qemu/hw/vga.c:1317: error:
> `vga_draw_line15_15bgr' undeclared here (not in a function)

Thanks, I split the patch and didn't notice that some parts didn't
survive the splitting. It should be fixed with the commit.

Re: [Qemu-devel] qemu/hw pixel_ops.h

[Stuart Brady]

On Sun, Jun 10, 2007 at 04:35:21PM +0000, Blue Swirl wrote:
> Log message:
> 	 Add hw/pixel_ops.h

Are there any thoughts on moving vga_draw_line_glyph* out of
vga_template.h?  While I'm not *entirely* certain that my ZX Spectrum
emulation patch[1] would be accepted :-), it seems conceivable that
moving these functions out of vga_template.h would be useful to others
at some point, so I'd be happy to submit a patch for this.

(It would have to be #includable from vga.c or vga_template.h, so
obviously this can't go in pixel_ops.h.)
-- 
Stuart Brady

[1] That's one d*mn fast Speccy, btw. :-)

Re: [Qemu-devel] qemu/hw pixel_ops.h

[Andreas Färber]

Am 10.06.2007 um 19:02 schrieb Blue Swirl:

> Thanks, I split the patch and didn't notice that some parts didn't
> survive the splitting. It should be fixed with the commit.

Thank you!

If this was only a splitting/committing issue then I'll assume I can  
still apply big_endian_display4.diff against 0.9.0; works so far anyway.

Andreas

Re: [Qemu-devel] qemu/hw pixel_ops.h

[Paul Brook]

On Sunday 10 June 2007, Stuart Brady wrote:
> On Sun, Jun 10, 2007 at 04:35:21PM +0000, Blue Swirl wrote:
> > Log message:
> > 	 Add hw/pixel_ops.h
>
> Are there any thoughts on moving vga_draw_line_glyph* out of
> vga_template.h?

Sounds like a good idea (in principle) to me. I suspect you'd want to move 
vga_template and chunks of of code from vga.c into a common blit routine.
The ARM pl110 CLCDC emulation could also benefit from this.

Paul

Re: [Qemu-devel] qemu/hw pixel_ops.h

[Blue Swirl]

On 6/10/07, Paul Brook <paul@codesourcery.com> wrote:
> On Sunday 10 June 2007, Stuart Brady wrote:
> > On Sun, Jun 10, 2007 at 04:35:21PM +0000, Blue Swirl wrote:
> > > Log message:
> > >      Add hw/pixel_ops.h
> >
> > Are there any thoughts on moving vga_draw_line_glyph* out of
> > vga_template.h?
>
> Sounds like a good idea (in principle) to me. I suspect you'd want to move
> vga_template and chunks of of code from vga.c into a common blit routine.
> The ARM pl110 CLCDC emulation could also benefit from this.

How about moving these and pixel_ops to sdl.c and other output
drivers? Then the emulated devices didn't have to know about output
device.

Re: [Qemu-devel] qemu/hw pixel_ops.h

[Paul Brook]

> How about moving these and pixel_ops to sdl.c and other output
> drivers? Then the emulated devices didn't have to know about output
> device.

They should also be independent of the output device (as they are now).

Paul