qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic
Date: Mon, 18 Jun 2007 22:08:54 +0200	[thread overview]
Message-ID: <20070618200852.GA16008@farad.aurel32.net> (raw)

Hi all,

The patch below fixes a segmentation fault when using the arm emulation
with -nographic.

Bye
Aurelien


Index: hw/versatilepb.c
===================================================================
RCS file: /sources/qemu/qemu/hw/versatilepb.c,v
retrieving revision 1.15
diff -u -d -p -r1.15 versatilepb.c
--- hw/versatilepb.c	3 Jun 2007 15:19:33 -0000	1.15
+++ hw/versatilepb.c	18 Jun 2007 20:04:22 -0000
@@ -10,6 +10,8 @@
 #include "vl.h"
 #include "arm_pic.h"
 
+extern int nographic;
+
 /* Primary interrupt controller.  */
 
 typedef struct vpb_sic_state
@@ -215,7 +217,8 @@ static void versatile_init(int ram_size,
 
     /* The versatile/PB actually has a modified Color LCD controller
        that includes hardware cursor support from the PL111.  */
-    pl110_init(ds, 0x10120000, pic[16], 1);
+    if (!nographic)
+        pl110_init(ds, 0x10120000, pic[16], 1);
 
     pl181_init(0x10005000, sd_bdrv, sic[22], sic[1]);
 #if 0


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

             reply	other threads:[~2007-06-18 20:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-18 20:08 Aurelien Jarno [this message]
2007-06-18 20:15 ` [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic Nigel Horne
2007-06-18 20:23   ` Aurelien Jarno
2007-06-18 21:13   ` [Qemu-devel] [PATCH] " Stefan Weil
2007-06-19 14:08     ` Aurelien Jarno
2007-06-18 20:25 ` [Qemu-devel] [PATCH, arm] " Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070618200852.GA16008@farad.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).