[Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic

[Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic

[Aurelien Jarno]

Hi all,

The patch below fixes a segmentation fault when using the arm emulation
with -nographic.

Bye
Aurelien


Index: hw/versatilepb.c
===================================================================
RCS file: /sources/qemu/qemu/hw/versatilepb.c,v
retrieving revision 1.15
diff -u -d -p -r1.15 versatilepb.c
--- hw/versatilepb.c	3 Jun 2007 15:19:33 -0000	1.15
+++ hw/versatilepb.c	18 Jun 2007 20:04:22 -0000
@@ -10,6 +10,8 @@
 #include "vl.h"
 #include "arm_pic.h"
 
+extern int nographic;
+
 /* Primary interrupt controller.  */
 
 typedef struct vpb_sic_state
@@ -215,7 +217,8 @@ static void versatile_init(int ram_size,
 
     /* The versatile/PB actually has a modified Color LCD controller
        that includes hardware cursor support from the PL111.  */
-    pl110_init(ds, 0x10120000, pic[16], 1);
+    if (!nographic)
+        pl110_init(ds, 0x10120000, pic[16], 1);
 
     pl181_init(0x10005000, sd_bdrv, sic[22], sic[1]);
 #if 0


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic

[Nigel Horne]

Aurelien Jarno wrote:
> Hi all,
>
> The patch below fixes a segmentation fault when using the arm emulation
> with -nographic.
>   
The sparc emulation in CVS also currently segaults with -nographic. Will 
this patch fix that as well?
> Bye
> Aurelien
>
>
>   
-Nigel

Re: [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic

[Aurelien Jarno]

Nigel Horne a écrit :
> Aurelien Jarno wrote:
>> Hi all,
>>
>> The patch below fixes a segmentation fault when using the arm emulation
>> with -nographic.
>>   
> The sparc emulation in CVS also currently segaults with -nographic. Will 
> this patch fix that as well?

Nope, this only fix arm versatile. All systems should be fixed, as it as
already be done for mips.


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic

[Paul Brook]

On Monday 18 June 2007, Aurelien Jarno wrote:
> Hi all,
>
> The patch below fixes a segmentation fault when using the arm emulation
> with -nographic.

No. This is the wrong way to fix this.
Fix the segfault, don't disable the device emulation. 

Paul

Re: [Qemu-devel] [PATCH] Segmentation fault when run with -nographic

[Stefan Weil]

I already sent a patch for this to the list:
http://lists.gnu.org/archive/html/qemu-devel/2007-06/msg00185.html

Stefan

Nigel Horne schrieb:
> Aurelien Jarno wrote:
>> Hi all,
>>
>> The patch below fixes a segmentation fault when using the arm emulation
>> with -nographic.
>>   
> The sparc emulation in CVS also currently segaults with -nographic.
> Will this patch fix that as well?
>> Bye
>> Aurelien
>>
>>
>>   
> -Nigel
>
>
>

Re: [Qemu-devel] [PATCH] Segmentation fault when run with -nographic

[Aurelien Jarno]

On Mon, Jun 18, 2007 at 11:13:04PM +0200, Stefan Weil wrote:
> I already sent a patch for this to the list:
> http://lists.gnu.org/archive/html/qemu-devel/2007-06/msg00185.html
> 

Indeed that is the correct way to fix that. Anybody to commit this
patch?

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net