From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I547o-000597-5E for qemu-devel@nongnu.org; Sun, 01 Jul 2007 14:26:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I547m-00058i-Q7 for qemu-devel@nongnu.org; Sun, 01 Jul 2007 14:26:19 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I547m-00058e-KY for qemu-devel@nongnu.org; Sun, 01 Jul 2007 14:26:18 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I547m-0003rl-67 for qemu-devel@nongnu.org; Sun, 01 Jul 2007 14:26:18 -0400 From: Paul Brook Subject: Re: [Qemu-devel] qemu exec.c monitor.c Date: Sun, 1 Jul 2007 19:26:08 +0100 References: <4687E465.9010505@mail.berlios.de> In-Reply-To: <4687E465.9010505@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200707011926.09003.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sunday 01 July 2007, Stefan Weil wrote: > ANSI / POSIX do not define "wa" as mode string for fopen. > I have no idea how many implementations of libc > will fail with this mode which was introduced by > the latest version of exec.c. > > The standard mode for append is just "a". You are correct. I've fixed this. > Even better (because it is faster and creates smaller > log files for Windows) is "ab" for append and "wb" > otherwise. We're writing human-readable text, so opening in binary mode is IMHO fairly dubious. If you really want fast logs/traces there are better ways to speed it up. Paul