From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I5M8k-0007Ci-VP for qemu-devel@nongnu.org; Mon, 02 Jul 2007 09:40:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I5M8j-0007Bg-8f for qemu-devel@nongnu.org; Mon, 02 Jul 2007 09:40:30 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I5M8j-0007BW-23 for qemu-devel@nongnu.org; Mon, 02 Jul 2007 09:40:29 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I5M8i-0006MC-Fc for qemu-devel@nongnu.org; Mon, 02 Jul 2007 09:40:28 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] ARM7TDMI emulation Date: Mon, 2 Jul 2007 14:40:24 +0100 References: <200707021527.54435.uli@suse.de> In-Reply-To: <200707021527.54435.uli@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200707021440.25061.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Monday 02 July 2007, Ulrich Hecht wrote: > Hi! > > This patch adds ARM7TDMI emulation with Thumb v1 (no BLX, no BKPT, ignore > bit 0 on POP PC) and without CP15. ARM_FEATURE_THUMB1 is a bad name for this. Thumb-1 covers both v4t and v5t. Thumb-2 is a completely new architecture revision which adds 32-bit instructions. You should add/use ARM_FEATURE_V5/ARCH(5) instead. For added confusion some older documentation refers to v5t as "thumb2", or the second revision of the Thumb ISA. This should be ignored :-) The ARM7TDMI implements the base updated abort model. You should either implement that, or pick a core (eg. 920t) that uses the base restored abort model. Paul