From: Rob Landley <rob@landley.net>
To: qemu-devel@nongnu.org
Cc: frederic.roussel@access-company.com,
Yigael Fleishman <igal.fl@gmail.com>
Subject: Re: [Qemu-devel] Missing system calls retries in case of EINTR
Date: Fri, 6 Jul 2007 14:57:07 -0400 [thread overview]
Message-ID: <200707061457.07925.rob@landley.net> (raw)
In-Reply-To: <a315cb3c0706251714nd05f5dbt8ca7fdef25a0f720@mail.gmail.com>
On Monday 25 June 2007 20:14:24 Yigael Fleishman wrote:
> Running qemu on a Ubuntu Feisty host I've encountered an occasional
> failure-to-launch problem.
> I've used the "-serial /dev/ttyS0" at the command line, and qemu would
> often exit printing "could not open serial device".
> Looking in the srcs I've noticed that qemu_chr_open_tty does not retry the
> 'open' syscall if it fails and errno=EINTR.
> I've added a retry for such case and it seems to solve that specific
> problem (see the following patch).
> Furthermore, I've noticed that all open, read and some write calls in
> vl.care not retried in such cases.
Please don't play whack-a-mole with this. You probably want
sigaction(SA_RESTART) when running system emulation.
Rob
--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
next prev parent reply other threads:[~2007-07-07 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 0:14 [Qemu-devel] Missing system calls retries in case of EINTR Yigael Fleishman
2007-07-06 18:57 ` Rob Landley [this message]
2007-07-11 0:57 ` Yigael Fleishman
2007-07-11 17:04 ` Rob Landley
2007-07-11 17:57 ` Yigael Fleishman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707061457.07925.rob@landley.net \
--to=rob@landley.net \
--cc=frederic.roussel@access-company.com \
--cc=igal.fl@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).