From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IAUE2-0002EZ-Cc
	for qemu-devel@nongnu.org; Mon, 16 Jul 2007 13:19:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IAUE1-0002E9-21
	for qemu-devel@nongnu.org; Mon, 16 Jul 2007 13:19:10 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IAUE0-0002Dz-PP
	for qemu-devel@nongnu.org; Mon, 16 Jul 2007 13:19:08 -0400
Received: from mx1.redhat.com ([66.187.233.31])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <berrange@redhat.com>) id 1IAUE0-0004hO-HW
	for qemu-devel@nongnu.org; Mon, 16 Jul 2007 13:19:08 -0400
Date: Mon, 16 Jul 2007 18:18:05 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] PATCH: Ensure RTL 8139 MMIO regions are 4k apart
Message-ID: <20070716171805.GI19538@redhat.com>
References: <20070716170325.GH19538@redhat.com>
	<200707161807.18786.paul@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200707161807.18786.paul@codesourcery.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On Mon, Jul 16, 2007 at 06:07:18PM +0100, Paul Brook wrote:
> > The hw/rtl8139.c code is passing  0x100 in as the size parameter for the
> > cpu_register_physical_memory call, despite the fact that the API contract
> > says size has to be a multiple of page size.
> 
> Have you tried recent CVS? This should not be necessary.

I thought I had - but my checkout was synced to the 0.9.0 release :-( Re-tested
with latest HEAD and it works OK without needing this patch. Sorry for the 
noise.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|