From: Bernhard Kauer <kauer@os.inf.tu-dresden.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Patch: PIC-i8259 mode transition wrong
Date: Tue, 31 Jul 2007 16:48:16 +0200 [thread overview]
Message-ID: <20070731144816.GB10391@chrom.inf.tu-dresden.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 96 bytes --]
The PIC initilization should respect the fourth byte init
bit in single mode.
Bernhard Kauer
[-- Attachment #2: qemu_pic_single_fix.diff --]
[-- Type: text/x-diff, Size: 561 bytes --]
Index: hw/i8259.c
===================================================================
RCS file: /sources/qemu/qemu/hw/i8259.c,v
retrieving revision 1.22
diff -u -r1.22 i8259.c
--- hw/i8259.c 7 Apr 2007 18:14:41 -0000 1.22
+++ hw/i8259.c 31 Jul 2007 14:31:14 -0000
@@ -351,7 +351,7 @@
break;
case 1:
s->irq_base = val & 0xf8;
- s->init_state = s->single_mode && s->init4 ? 3 : 2;
+ s->init_state = s->single_mode ? (s->init4 ? 3 : 0) : 2;
break;
case 2:
if (s->init4) {
reply other threads:[~2007-07-31 14:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731144816.GB10391@chrom.inf.tu-dresden.de \
--to=kauer@os.inf.tu-dresden.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).