From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IFt1M-0005HT-0U
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 10:48:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IFt1G-0005Cx-PY
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 10:48:23 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IFt1G-0005CX-GP
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 10:48:18 -0400
Received: from os.inf.tu-dresden.de ([141.76.48.99])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kauer@os.inf.tu-dresden.de>) id 1IFt1F-0005ad-VX
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 10:48:18 -0400
Received: from chrom.inf.tu-dresden.de ([141.76.48.24])
	by os.inf.tu-dresden.de with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67)
	id 1IFt1E-0004ia-Iw
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 16:48:16 +0200
Received: from kauer by chrom.inf.tu-dresden.de with local (Exim 4.67)
	(envelope-from <kauer@chrom.inf.tu-dresden.de>) id 1IFt1E-0002nz-H8
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 16:48:16 +0200
Date: Tue, 31 Jul 2007 16:48:16 +0200
Message-ID: <20070731144816.GB10391@chrom.inf.tu-dresden.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="l76fUT7nc3MelDdI"
Content-Disposition: inline
From: Bernhard Kauer <kauer@os.inf.tu-dresden.de>
Subject: [Qemu-devel] Patch: PIC-i8259 mode transition wrong
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


--l76fUT7nc3MelDdI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

The PIC initilization should respect the fourth byte init
bit in single mode.


	Bernhard Kauer

--l76fUT7nc3MelDdI
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="qemu_pic_single_fix.diff"

Index: hw/i8259.c
===================================================================
RCS file: /sources/qemu/qemu/hw/i8259.c,v
retrieving revision 1.22
diff -u -r1.22 i8259.c
--- hw/i8259.c	7 Apr 2007 18:14:41 -0000	1.22
+++ hw/i8259.c	31 Jul 2007 14:31:14 -0000
@@ -351,7 +351,7 @@
             break;
         case 1:
             s->irq_base = val & 0xf8;
-            s->init_state = s->single_mode && s->init4 ? 3 : 2;
+            s->init_state = s->single_mode ? (s->init4 ? 3 : 0) : 2;
             break;
         case 2:
             if (s->init4) {

--l76fUT7nc3MelDdI--