qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] S/390 host fixed
Date: Wed, 1 Aug 2007 02:02:13 +0100	[thread overview]
Message-ID: <200708010202.15583.paul@codesourcery.com> (raw)
In-Reply-To: <20070731235915.GL26960@networkno.de>

> >  void op_cfc1 (void)
> >  {
> > +#ifdef __s390__
> > +    if(!T1)
> > +        T0 = (int32_t)env->fcr0;
>
> I guess this breaks when you _breathe_ at the compiler. Inventing
> switch-table support in dyngen would be preferable (if possible...).

Actually, I'm surprised this doesn't break on other hosts. Jump tables are 
death on all targets, I guess s390 gcc happens to use different heuristics 
for expanding switch statements.

I suspect making dyngen handle jump tables is not going to happen.

Paul

  reply	other threads:[~2007-08-01  1:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30 11:49 [Qemu-devel] [PATCH] S/390 host fixed Ulrich Hecht
2007-07-30 12:37 ` Sunil Amitkumar Janki
2007-07-30 14:05 ` Ulrich Hecht
2007-07-31 23:59   ` Thiemo Seufer
2007-08-01  1:02     ` Paul Brook [this message]
2007-08-01 13:58       ` Dan Shearer
2007-08-01 14:23         ` [Qemu-devel] replacing dyngen (was: S/390 host fixed) Paul Brook
2007-08-01 14:31           ` Dan Shearer
2007-08-01 14:47             ` Paul Brook
2007-08-01 13:44     ` [Qemu-devel] [PATCH] S/390 host fixed Ulrich Hecht
2007-09-13  4:21       ` Thiemo Seufer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708010202.15583.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).