From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IG2bh-0006Nj-S8
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 21:02:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IG2bg-0006NW-OJ
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 21:02:32 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IG2bg-0006NT-Gk
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 21:02:32 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1IG2bf-0003U8-Ra
	for qemu-devel@nongnu.org; Tue, 31 Jul 2007 21:02:32 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] S/390 host fixed
Date: Wed, 1 Aug 2007 02:02:13 +0100
References: <200707301349.26745.uli@suse.de> <200707301605.47719.uli@suse.de>
	<20070731235915.GL26960@networkno.de>
In-Reply-To: <20070731235915.GL26960@networkno.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200708010202.15583.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> >  void op_cfc1 (void)
> >  {
> > +#ifdef __s390__
> > +    if(!T1)
> > +        T0 = (int32_t)env->fcr0;
>
> I guess this breaks when you _breathe_ at the compiler. Inventing
> switch-table support in dyngen would be preferable (if possible...).

Actually, I'm surprised this doesn't break on other hosts. Jump tables are 
death on all targets, I guess s390 gcc happens to use different heuristics 
for expanding switch statements.

I suspect making dyngen handle jump tables is not going to happen.

Paul