qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Kauer <kauer@chrom.inf.tu-dresden.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Patch: let qemu work with latest bochsbios
Date: Sat, 4 Aug 2007 15:05:47 +0200	[thread overview]
Message-ID: <20070804130547.GB20760@chrom.inf.tu-dresden.de> (raw)
In-Reply-To: <46B0AEB2.9040709@codemonkey.ws>

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On Wed, Aug 01, 2007 at 11:02:58AM -0500, Anthony Liguori wrote:
> Bernhard Kauer wrote:
>> -	boot_device = 'c'; /* to prevent confusion by the BIOS */
>> +	//boot_device = 'c'; /* to prevent confusion by the BIOS */
>>      }
>>   
>
> Please don't comment out code.  Just delete it.

You are right. At the time i changed it I just wondered what the
comment means...


	Bernhard

[-- Attachment #2: qemu_boot_device.diff --]
[-- Type: text/x-diff, Size: 908 bytes --]

Index: vl.c
===================================================================
RCS file: /sources/qemu/qemu/vl.c,v
retrieving revision 1.323
diff -u -r1.323 vl.c
--- vl.c	29 Jul 2007 17:57:25 -0000	1.323
+++ vl.c	4 Aug 2007 13:05:28 -0000
@@ -7828,7 +7828,6 @@
 	    fprintf(stderr, "No valid PXE rom found for network device\n");
 	    exit(1);
 	}
-	boot_device = 'c'; /* to prevent confusion by the BIOS */
     }
 #endif
 
Index: hw/pc.c
===================================================================
RCS file: /sources/qemu/qemu/hw/pc.c,v
retrieving revision 1.81
diff -u -r1.81 pc.c
--- hw/pc.c	6 Jun 2007 16:26:13 -0000	1.81
+++ hw/pc.c	4 Aug 2007 13:05:29 -0000
@@ -197,6 +197,9 @@
     case 'd':
         rtc_set_memory(s, 0x3d, 0x03); /* CD-ROM boot */
         break;
+    case 'n':
+        rtc_set_memory(s, 0x3d, 0x04); /* Network boot */
+        break;	
     }
 
     /* floppy type */

  reply	other threads:[~2007-08-04 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 15:42 [Qemu-devel] Patch: let qemu work with latest bochsbios Bernhard Kauer
2007-08-01 16:02 ` Anthony Liguori
2007-08-04 13:05   ` Bernhard Kauer [this message]
2007-08-17 16:48 ` Bernhard Kauer
  -- strict thread matches above, loose matches on Subject: below --
2007-08-01 15:41 Bernhard Kauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070804130547.GB20760@chrom.inf.tu-dresden.de \
    --to=kauer@chrom.inf.tu-dresden.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).