qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] Re: Extending qemu_irq for reset signals
Date: Wed, 15 Aug 2007 20:44:22 +0100	[thread overview]
Message-ID: <200708152044.23716.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580708151233i79fd915dg2ff585aaee0e613a@mail.gmail.com>

> I implemented reset that way with qemu_irq, the result survives some
> quick tests.

I'd probably make it take notice of the level parameter, and lower the line 
immediately after raising it. Future implementations of qemu_irq may cache 
the value internally.

Other than that, looks ok, though your patch doesn't apply against current 
cvs.

Paul

  reply	other threads:[~2007-08-15 19:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-15 16:13 [Qemu-devel] Extending qemu_irq for reset signals Blue Swirl
2007-08-15 16:34 ` [Qemu-devel] " Paul Brook
2007-08-15 16:53   ` Blue Swirl
2007-08-15 17:21     ` Paul Brook
2007-08-15 17:22       ` Paul Brook
2007-08-15 17:35         ` Blue Swirl
2007-08-15 17:42           ` Paul Brook
2007-08-15 17:52             ` Blue Swirl
2007-08-15 19:33               ` Blue Swirl
2007-08-15 19:44                 ` Paul Brook [this message]
2007-08-15 17:47           ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708152044.23716.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).