From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ILOnA-0005ea-At
	for qemu-devel@nongnu.org; Wed, 15 Aug 2007 15:44:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ILOn7-0005WX-FE
	for qemu-devel@nongnu.org; Wed, 15 Aug 2007 15:44:31 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ILOn7-0005Vw-6E
	for qemu-devel@nongnu.org; Wed, 15 Aug 2007 15:44:29 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1ILOn6-0005bU-MB
	for qemu-devel@nongnu.org; Wed, 15 Aug 2007 15:44:28 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: Extending qemu_irq for reset signals
Date: Wed, 15 Aug 2007 20:44:22 +0100
References: <f43fc5580708150913k631126bche7fde54f55e73643@mail.gmail.com>
	<f43fc5580708151052m2d8e1423m5931a7f56bc0c424@mail.gmail.com>
	<f43fc5580708151233i79fd915dg2ff585aaee0e613a@mail.gmail.com>
In-Reply-To: <f43fc5580708151233i79fd915dg2ff585aaee0e613a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200708152044.23716.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

> I implemented reset that way with qemu_irq, the result survives some
> quick tests.

I'd probably make it take notice of the level parameter, and lower the line 
immediately after raising it. Future implementations of qemu_irq may cache 
the value internally.

Other than that, looks ok, though your patch doesn't apply against current 
cvs.

Paul