[Qemu-devel] sh4 mov.b fix

[Qemu-devel] sh4 mov.b fix

[Vince Weaver]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 113 bytes --]

Hello

I think this patch is needed for proper implementation of
the sh4 mov.b @(disp,Rm),R0 instruction.

Vince

[-- Attachment #2: Type: TEXT/PLAIN, Size: 625 bytes --]

--- ./qemu-snapshot-2007-08-14_05/target-sh4/translate.c	2007-08-24 01:48:47.000000000 -0400
+++ ./qemu-snapshot-2007-08-14_05/target-sh4/translate.c.orig	2007-08-24 01:37:56.000000000 -0400
@@ -879,10 +879,10 @@
 	gen_op_stw_T0_T1(ctx);
 	return;
     case 0x8400:		/* mov.b @(disp,Rn),R0 */
-	gen_op_movl_rN_T0(REG(B7_4));
-	gen_op_addl_imm_T0(B3_0);
-	gen_op_ldb_T0_T0(ctx);
-	gen_op_movl_T0_rN(REG(0));
+	gen_op_movl_rN_T0(REG(0));
+	gen_op_movl_rN_T1(REG(B7_4));
+	gen_op_addl_imm_T1(B3_0);
+	gen_op_stb_T0_T1(ctx);
 	return;
     case 0x8500:		/* mov.w @(disp,Rn),R0 */
 	gen_op_movl_rN_T0(REG(B7_4));

Re: [Qemu-devel] sh4 mov.b fix

[Vince Weaver]

> I think this patch is needed for proper implementation of
> the sh4 mov.b @(disp,Rm),R0 instruction.

and of course, I managed to send a reversed patch.  That will teach me to
send out things like that late at night.  Here's the proper patch.

Vince

--- ./qemu-snapshot-2007-08-14_05/target-sh4/translate.c.orig	2007-08-24 01:37:56.000000000 -0400
+++ ./qemu-snapshot-2007-08-14_05/target-sh4/translate.c	2007-08-24 01:48:47.000000000 -0400
@@ -879,10 +879,10 @@
 	gen_op_stw_T0_T1(ctx);
 	return;
     case 0x8400:		/* mov.b @(disp,Rn),R0 */
-	gen_op_movl_rN_T0(REG(0));
-	gen_op_movl_rN_T1(REG(B7_4));
-	gen_op_addl_imm_T1(B3_0);
-	gen_op_stb_T0_T1(ctx);
+	gen_op_movl_rN_T0(REG(B7_4));
+	gen_op_addl_imm_T0(B3_0);
+	gen_op_ldb_T0_T0(ctx);
+	gen_op_movl_T0_rN(REG(0));
 	return;
     case 0x8500:		/* mov.w @(disp,Rn),R0 */
 	gen_op_movl_rN_T0(REG(B7_4));