From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IOfcY-00064V-59 for qemu-devel@nongnu.org; Fri, 24 Aug 2007 16:19:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IOfcW-00061R-7u for qemu-devel@nongnu.org; Fri, 24 Aug 2007 16:19:05 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IOfcV-00060w-L6 for qemu-devel@nongnu.org; Fri, 24 Aug 2007 16:19:03 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IOfcS-0003Pr-Ow for qemu-devel@nongnu.org; Fri, 24 Aug 2007 16:19:01 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: PATCH, RFC: Generic DMA framework Date: Fri, 24 Aug 2007 21:18:52 +0100 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708242118.54118.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl On Friday 24 August 2007, Blue Swirl wrote: > I have now converted the ISA DMA devices (SB16, FDC), most PCI devices > and targets. > > gdma.diff: Generic DMA > pc_ppc_dma_to_gdma.diff: Convert x86 and PPC to GDMA > pc_sb16_to_gdma.diff: Convert SB16 to GDMA > pc_fdc_to_gdma.diff: FDC > pc_dma_cleanup.diff: Remove unused functions > sparc_gdma.diff: Convert Sparc32 to GDMA > sparc32_dma_esp_le_to_gdma.diff: Convert ESP and Lance > sun4c.diff: Preliminary Sun4c (Sparcstation-1) support > pci_gdma.diff: Convert PCI devices and targets > > Any comments? The patches are a bit intrusive and I can't test the > targets except that they compile. Shouldn't the PCI DMA object be a property of the PCI bus? ie. we don't want/need to pass it round as a separate parameter. It can be inferred form the device/bus. Paul