From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ia66Z-0006s8-P7
	for qemu-devel@nongnu.org; Tue, 25 Sep 2007 04:49:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ia66X-0006re-5X
	for qemu-devel@nongnu.org; Tue, 25 Sep 2007 04:49:18 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ia66W-0006rY-Qz
	for qemu-devel@nongnu.org; Tue, 25 Sep 2007 04:49:16 -0400
Received: from il.qumranet.com ([82.166.9.18])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <danken@qumranet.com>) id 1Ia66W-0000pE-E9
	for qemu-devel@nongnu.org; Tue, 25 Sep 2007 04:49:16 -0400
Date: Tue, 25 Sep 2007 10:48:42 +0200
From: Dan Kenigsberg <danken@qumranet.com>
Subject: Re: [kvm-devel] [Qemu-devel] expose host CPU features to guests:
	Take 3
Message-ID: <20070925084842.GA14221@karma.qumranet.com>
References: <20070905174530.GA3945@karma.qumranet.com>
	<20070910074005.GA26869@karma.qumranet.com>
	<20070924174129.GA4507@karma.qumranet.com>
	<fb249edb0709241828pb6b9fd4v1d1d8d4a3495f040@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fb249edb0709241828pb6b9fd4v1d1d8d4a3495f040@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, qemu-devel@nongnu.org

On Tue, Sep 25, 2007 at 03:28:24AM +0200, andrzej zaborowski wrote:
> Hi,
> 
> On 24/09/2007, Dan Kenigsberg <danken@qumranet.com> wrote:
> > As with previous "Takes" of this patch, its purpose is to expose host
> > +{
> > +    asm("cpuid"
> > +        : "=a" (*ax),
> > +          "=b" (*bx),
> > +          "=c" (*cx),
> > +          "=d" (*dx)
> > +        : "a" (function));
> > +}
> 
> I haven't really read through the rest of your code but this piece
> appears to be outside any #ifdef/#endif so it will only build on x86.

I might be missing something here, but isn't not being on the
TARGET_PATH of Makefile.target enough? I don't see #ifdef TARGET_I386
elsewhere under target-i386. I don't mind adding extra protection, I
just be happy to better understand the whats and whys.

Dan.