From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IaZFO-0002jG-1j
	for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:56:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IaZFN-0002iz-I4
	for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:56:21 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IaZFN-0002iw-BS
	for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:56:21 -0400
Received: from mx1.redhat.com ([66.187.233.31])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <berrange@redhat.com>) id 1IaZFM-0003It-2o
	for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:56:20 -0400
Date: Wed, 26 Sep 2007 16:55:31 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20070926155531.GB29729@redhat.com>
References: <E1IaFcv-0003fu-Oi@sc8-sf-web22.sourceforge.net>
	<46FA7F08.4070109@bull.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <46FA7F08.4070109@bull.net>
Subject: [Qemu-devel] Re: [kvm-devel] [ kvm-Bugs-1802223 ] nics have same hw
	address (rtl8139)
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

On Wed, Sep 26, 2007 at 05:47:20PM +0200, Laurent Vivier wrote:
> Hi,
> 
> I think there is a bug in qemu RTL8139.
> 
> RTL8139 uses:
> 
> cpu_register_physical_memory(addr + 0, 0x100, s->rtl8139_mmio_io_addr);
> 
> But in the comment of cpu_register_physical_memory() we have:
> 
> "'size' must be a multiple of the target page size."
> 
> And I think 0x100 is not a multiple of target page size.... :-P

Latest upstream QEMU has fixed its memory handling so that MMIO regions
do not need to be a multiple of page size. Changing RTL8139 to use a
block of size 0x1000 is a reasonable short term hack around the problem,
but syncing with latest QEMU is the real solution, since there are other
places in the code which will have similar issues.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|