From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ic09W-0004OJ-I1
	for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:52:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ic09V-0004M6-CS
	for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:52:13 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ic09U-0004Lk-Tz
	for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:52:12 -0400
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1Ic09U-0002Ap-Os
	for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:52:12 -0400
Date: Sun, 30 Sep 2007 14:38:39 +0100
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] RFC: cleanups in ELF loader
Message-ID: <20070930133839.GD13317@networkno.de>
References: <1191116355.29900.86.camel@rapid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1191116355.29900.86.camel@rapid>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "J. Mayer" <l_indien@magic.fr>
Cc: qemu-devel@nongnu.org

J. Mayer wrote:
> Following what I've done in the syscalls emulation routines, it appeared
> to me that there seems to be a lot of confusions between host and target
> long in the ELF loader.

But the ELF fields are tied to the ELFCLASS of the supported ABI, not to
the register width of the machine emulation. If anything they should
become the ELF types.

(Your approach will e.g. break down for MIPS N32, where "long" is smaller
thant the register width, and the ABI uses ELFCLASS32.)

> I tried to fix this. I also noticed that the image infos start_data
> field was not computed as the Linux kernel does. As the ARM and the
> Alpha targets use this information to initialize the program state
> before execution, it seems a good idea (to me !) to fix it.

This part looks reasonable.


Thiemo