From: Dan Kenigsberg <danken@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] vmmouse with Fedora-6 64bit guest
Date: Mon, 8 Oct 2007 15:23:06 +0200 [thread overview]
Message-ID: <20071008132305.GA8786@karma.qumranet.com> (raw)
In-Reply-To: <46F91183.4010805@codemonkey.ws>
In X's vmmouse_drv, the magic number is defined as uint32_t. Therefore
the top half of the 64 bit ax register is garbage that should be
ignored. This makes fc6 guest's vmmouse work.
Index: hw/vmport.c
===================================================================
RCS file: /sources/qemu/qemu/hw/vmport.c,v
retrieving revision 1.1
diff -u -p -r1.1 vmport.c
--- hw/vmport.c 26 Aug 2007 17:48:12 -0000 1.1
+++ hw/vmport.c 8 Oct 2007 13:11:45 -0000
@@ -55,7 +55,7 @@ static uint32_t vmport_ioport_read(void
target_ulong eax;
eax = s->env->regs[R_EAX];
- if (eax != VMPORT_MAGIC)
+ if ((uint32_t)eax != VMPORT_MAGIC)
return eax;
command = s->env->regs[R_ECX];
next prev parent reply other threads:[~2007-10-08 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 13:36 [Qemu-devel] -usbdevice tablet with Fedora-6 64bit guest Dan Kenigsberg
2007-09-20 13:41 ` Daniel P. Berrange
2007-09-25 12:03 ` Dan Kenigsberg
2007-09-25 12:29 ` [Qemu-devel] vmmouse " Dan Kenigsberg
2007-09-25 13:43 ` Dor Laor
2007-09-25 13:47 ` Anthony Liguori
2007-09-25 14:49 ` Dan Kenigsberg
2007-10-08 13:23 ` Dan Kenigsberg [this message]
2007-10-08 14:55 ` Anthony Liguori
2007-10-08 15:37 ` Dan Kenigsberg
2007-09-25 22:06 ` [Qemu-devel] -usbdevice tablet " Daniel P. Berrange
2007-09-26 12:52 ` Dan Kenigsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071008132305.GA8786@karma.qumranet.com \
--to=danken@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).