qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "J. Mayer" <l_indien@magic.fr>
Subject: Re: [Qemu-devel] RFC: Code fetch optimisation
Date: Tue, 16 Oct 2007 23:00:27 +0100	[thread overview]
Message-ID: <200710162300.27862.paul@codesourcery.com> (raw)
In-Reply-To: <1192566444.9976.510.camel@rapid>

> Well, we got the same behavior on PowerPC. What I was thinking of is
> that if we fix the VLE problems, the fix, if done in a proper way, could
> also allow benefit to RISC targets. What I don't know is; would we
> really have a benefit not stopping translation on page boundaries ?

> > For VLE targets we already get this wrong (the prefetch abort occurs some
> > time before the faulting instruction executes). I don't know if this
> > behavior is permitted by the ISA, but it's definitely possible to
> > construct cases where it has visible effect.
>
> I think that it would be possible to do things properly.
> [...] Or maybe the solution would
> just be to stop the translation knowing that the exception will be
> raised when trying to translate the first instruction in the next page.

I'd go for this one. It's approximately the same method currently used for 
RISC targets.

In general think this will require target specific support. For RISC targets 
this is trivial. For x86/m68k figuring out the length of an insn is trickier.

Detecting crossing a page boundary on subsequent insns in the load/mmu 
routines is problematic because it happens relatively late. In particular it 
may theoretically happen after we've output ops that change CPU state.

I suspect the best solution is to backtrack (remove the generated ops) after 
decoding the insn if we discover we've passed a page boundary. The ld*_code 
routines can simply return garbage (e.g. zero) if the read is not on the 
first page.

Trying to generate prefetch aborts at runtime sounds too hairy for my liking.

Paul

  reply	other threads:[~2007-10-16 22:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-14 11:44 [Qemu-devel] RFC: Code fetch optimisation J. Mayer
2007-10-15  2:30 ` Paul Brook
2007-10-15 12:09   ` J. Mayer
2007-10-15 16:01     ` Paul Brook
2007-10-15 16:19       ` Fabrice Bellard
2007-10-15 21:30       ` J. Mayer
2007-10-15 22:42         ` Paul Brook
2007-10-16 20:27           ` J. Mayer
2007-10-16 22:00             ` Paul Brook [this message]
2007-10-16 23:38               ` J. Mayer
2007-10-17  0:43                 ` Paul Brook
2007-10-16 22:26             ` Paul Brook
  -- strict thread matches above, loose matches on Subject: below --
2007-10-12  8:33 J. Mayer
2007-10-12 15:21 ` Blue Swirl
2007-10-12 18:24   ` Jocelyn Mayer
2007-10-12 18:36   ` Fabrice Bellard
2007-10-12 18:39   ` Fabrice Bellard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710162300.27862.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=l_indien@magic.fr \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).