[Qemu-devel] [RFC/PATCH] remove $check_gfx from configure

[Qemu-devel] [RFC/PATCH] remove $check_gfx from configure

[Carlo Marcelo Arenas Belon]

The following patch removes check_gfx from qemu's configure as the check it
was trying to enforce is no longer valid.

If neither sdl or cocoa are available, the video output for the console will 
be still available from the vnc server (which can't be disabled).

Carlo

---
Index: configure
===================================================================
RCS file: /sources/qemu/qemu/configure,v
retrieving revision 1.165
diff -u -r1.165 configure
--- configure	18 Oct 2007 20:51:48 -0000	1.165
+++ configure	23 Oct 2007 01:01:50 -0000
@@ -98,7 +98,6 @@
 kqemu="no"
 profiler="no"
 cocoa="no"
-check_gfx="yes"
 check_gcc="yes"
 softmmu="yes"
 linux_user="no"
@@ -276,8 +275,6 @@
   ;;
   --enable-cocoa) cocoa="yes" ; coreaudio="yes" ; sdl="no"
   ;;
-  --disable-gfx-check) check_gfx="no"
-  ;;
   --disable-gcc-check) check_gcc="no"
   ;;
   --disable-system) softmmu="no"
@@ -966,12 +963,10 @@
     ;;
 esac
 
-if test "$target_user_only" = "no" -a "$check_gfx" = "yes" \
-        -a "$sdl" = "no" -a "$cocoa" = "no" ; then
-    echo "ERROR: QEMU requires SDL or Cocoa for graphical output"
-    echo "To build QEMU without graphical output configure with --disable-gfx-check"
-    echo "Note that this will disable all output from the virtual graphics card."
-    exit 1;
+if test "$target_user_only" = "no" -a "$sdl" = "no" -a "$cocoa" = "no" ; then
+    echo "WARNING: QEMU requires SDL or Cocoa for graphical output"
+    echo "Note that in order to be able to attach to the console you'll"
+    echo "need to start qemu's vncserver with --vnc and use a vnc client."
 fi
 
 #echo "Creating $config_mak, $config_h and $target_dir/Makefile"

Re: [Qemu-devel] [RFC/PATCH] remove $check_gfx from configure

[J. Mayer]

On Mon, 2007-10-22 at 20:09 -0500, Carlo Marcelo Arenas Belon wrote:
> The following patch removes check_gfx from qemu's configure as the check it
> was trying to enforce is no longer valid.
> 
> If neither sdl or cocoa are available, the video output for the console will 
> be still available from the vnc server (which can't be disabled).

Then, it seems better to me to be add an option to disable the VNC
server. Why should we have a graphical output when we want to emulate
boards that don't have any kind of graphical devices ?

[...]

-- 
J. Mayer <l_indien@magic.fr>
Never organized