From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IkfR1-0005Kl-L0
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 08:34:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IkfQy-0005Hn-NA
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 08:34:05 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IkfQw-0005G7-7z
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 08:34:02 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1IkfQu-0001lO-7C
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 08:34:00 -0400
Date: Wed, 24 Oct 2007 13:33:44 +0100
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH] Physical hard disk drive for win32
Message-ID: <20071024123344.GA6666@networkno.de>
References: <001d01c6df8e$2de302c0$0464a8c0@athlon>
	<7fac565a0609240214u5eca5cedka8a023ab562a87f7@mail.gmail.com>
	<002501c6dfd2$5e5ae820$0464a8c0@athlon>
	<47190FA7.80108@mail.berlios.de>
	<219e947f0710220433l1d652092kd238d6ccb8aeb95a@mail.gmail.com>
	<471CEB10.9030600@mail.berlios.de>
	<219e947f0710240246w4532d346pce373fa62a17c77d@mail.gmail.com>
	<Pine.LNX.4.64.0710241101060.25221@racer.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0710241101060.25221@racer.site>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: qemu-devel@nongnu.org, Ivan Kalvachev <ikalvachev@gmail.com>

Johannes Schindelin wrote:
> Hi,
> 
> On Wed, 24 Oct 2007, Ivan Kalvachev wrote:
> 
> > 2007/10/22, Stefan Weil <weil@mail.berlios.de>:
> > > Ivan Kalvachev schrieb:
> > > > According to http://msdn2.microsoft.com/en-us/library/aa365171.aspx
> > > >
> > > > this function requires Win XP or Vista.
> > > > Is qemu supported only on these?
> > > Good question. The old IOCTL_DISK_GET_DRIVE_GEOMETRY
> > > was also supported for W2K. Will QEMU support W2K as a host
> > > longer than MS does? It would make things easier if we
> > > dropped support for W2K hosts.
> > >
> > > If we need host support for W2K, I'll check another method
> > > to get the disk size (reading size of partition 0) and send
> > > a new patch. Please send your feedback in this case.
> > >
> > > I hope we don't need W95 or W98 host support!?
> > 
> > Why not. :P
> > 
> > Anyway, calling the old ioctl code if the new one fails, should be
> > compatible enough. (and the new structure contains the old one, so no
> > need of having 2 variables).
> 
> It is not just that.  You'll have to guard the new ioctl within #ifdef's 
> so that it still compiles on MinGW, even if that version does not define 
> the constant.
> 
> Staying backwards compatible in this case is so easy, it is not even 
> funny.  (And certainly no reason to groan over having to support it.)

A undirected remark to the general public: If somebody comes up with a
patch for better backward compatibility I'll certainly consider it.


Thiemo
>