Re: [Qemu-devel] PreP kernels boot using Qemu

[Rob Landley <rob@landley.net>]

On Saturday 27 October 2007 3:07:05 am Aurelien Jarno wrote:
> Rob Landley a écrit :
> > On Monday 22 October 2007 11:28:10 am Aurelien Jarno wrote:
> >> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> >>
> >> diff --git a/arch/ppc/syslib/i8259.c b/arch/ppc/syslib/i8259.c
> >> index 1e5a00a..559f27c 100644
> >> --- a/arch/ppc/syslib/i8259.c
> >> +++ b/arch/ppc/syslib/i8259.c
> >> @@ -127,6 +127,7 @@ static void i8259_unmask_irq(unsigned int irq_nr)
> >>  static struct irq_chip i8259_pic = {
> >>  	.typename	= " i8259    ",
> >>  	.mask		= i8259_mask_irq,
> >> +	.disable	= i8259_mask_irq,
> >>  	.unmask		= i8259_unmask_irq,
> >>  	.mask_ack	= i8259_mask_and_ack_irq,
> >>  };
> >
> > Using mdm's qemu target platform and the 4k bios that supplies a device
> > tree, I applied this but it didn't make any difference in the ne2k-pci
> > adapter (not that I noticed).  It still doesn't bind to anything during
> > bootup.  (There's no eth0.)
>
> You need this patch to get the *ISA* NE2000 card working, the PCI one
> still doesn't work.

Hmmm, Milton's ppc_qemu patch forgot to add PPC_QEMU to the ISA dependency 
list along with PREP and CHRP.  Let's see, patch that, switch on the config 
symbol, build in that driver and...  Nope:

> ne.c:v1.10 9/23/94 Donald Becker (becker@scyld.com)
> Last modified Nov 1, 2000 by Paul Gortmaker
> NE*000 ethercard probe at 0x300: failed to detect IRQ line.

I still have no eth0.

I just confirmed that arch/powerpc/sysdev/i8259.c has:
static struct irq_chip i8259_pic = {
        .typename       = " i8259    ",
        .mask           = i8259_mask_irq,
        .disable        = i8259_mask_irq,
        .unmask         = i8259_unmask_irq,
        .mask_ack       = i8259_mask_and_ack_irq,
};

Since your patch was to /arch/ppc instead...

Any ideas?

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.