From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Im4P4-0000RT-3E
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 05:25:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Im4P2-0000JI-H0
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 05:25:53 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Im4P2-0000Is-Dl
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 05:25:52 -0400
Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]
	helo=grelber.thyrsus.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rob@landley.net>) id 1Im4P2-00054W-Aq
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 05:25:52 -0400
From: Rob Landley <rob@landley.net>
Subject: Re: [Qemu-devel] PreP kernels boot using Qemu
Date: Sun, 28 Oct 2007 05:25:23 -0500
References: <1193038567.16781.108.camel@rapid>
	<200710270300.55102.rob@landley.net> <4722F1A9.3000909@aurel32.net>
In-Reply-To: <4722F1A9.3000909@aurel32.net>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-15"
Message-Id: <200710280525.23540.rob@landley.net>
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On Saturday 27 October 2007 3:07:05 am Aurelien Jarno wrote:
> Rob Landley a =E9crit :
> > On Monday 22 October 2007 11:28:10 am Aurelien Jarno wrote:
> >> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> >>
> >> diff --git a/arch/ppc/syslib/i8259.c b/arch/ppc/syslib/i8259.c
> >> index 1e5a00a..559f27c 100644
> >> --- a/arch/ppc/syslib/i8259.c
> >> +++ b/arch/ppc/syslib/i8259.c
> >> @@ -127,6 +127,7 @@ static void i8259_unmask_irq(unsigned int irq_nr=
)
> >>  static struct irq_chip i8259_pic =3D {
> >>  	.typename	=3D " i8259    ",
> >>  	.mask		=3D i8259_mask_irq,
> >> +	.disable	=3D i8259_mask_irq,
> >>  	.unmask		=3D i8259_unmask_irq,
> >>  	.mask_ack	=3D i8259_mask_and_ack_irq,
> >>  };
> >
> > Using mdm's qemu target platform and the 4k bios that supplies a devi=
ce
> > tree, I applied this but it didn't make any difference in the ne2k-pc=
i
> > adapter (not that I noticed).  It still doesn't bind to anything duri=
ng
> > bootup.  (There's no eth0.)
>
> You need this patch to get the *ISA* NE2000 card working, the PCI one
> still doesn't work.

Hmmm, Milton's ppc_qemu patch forgot to add PPC_QEMU to the ISA dependenc=
y=20
list along with PREP and CHRP.  Let's see, patch that, switch on the conf=
ig=20
symbol, build in that driver and...  Nope:

> ne.c:v1.10 9/23/94 Donald Becker (becker@scyld.com)
> Last modified Nov 1, 2000 by Paul Gortmaker
> NE*000 ethercard probe at 0x300: failed to detect IRQ line.

I still have no eth0.

I just confirmed that arch/powerpc/sysdev/i8259.c has:
static struct irq_chip i8259_pic =3D {
        .typename       =3D " i8259    ",
        .mask           =3D i8259_mask_irq,
        .disable        =3D i8259_mask_irq,
        .unmask         =3D i8259_unmask_irq,
        .mask_ack       =3D i8259_mask_and_ack_irq,
};

Since your patch was to /arch/ppc instead...

Any ideas?

Rob
--=20
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.