From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ImAlc-0005ak-Fc
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 12:13:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ImAla-0005Zt-TR
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 12:13:35 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ImAla-0005Zo-Gb
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 12:13:34 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1ImAla-0002rS-77
	for qemu-devel@nongnu.org; Sun, 28 Oct 2007 12:13:34 -0400
Date: Sun, 28 Oct 2007 16:13:28 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] Proposal for host-utils
Message-ID: <20071028161327.GA22287@networkno.de>
References: <1193525625.16781.318.camel@rapid>
	<1193576560.16781.322.camel@rapid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1193576560.16781.322.camel@rapid>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "J. Mayer" <l_indien@magic.fr>
Cc: qemu-devel@nongnu.org

J. Mayer wrote:
> 
> On Sun, 2007-10-28 at 00:53 +0200, J. Mayer wrote:
> > Following the previous discussions about host-utils implementations,
> > here's a patch with the following changes:
> > - move mulu64 and muls64 definitions from exec.h to host-utils.h, for
> > consistency
> > - include host-utils.h in more files to reflect this change
> > - make the optimized version of mulu64 / muls64 for amd64 hosts static
> > inline
> > - change clz64 to avoid 64 bits logical operations to optimize the 32
> > bits host case
> > - add ctz32, ctz64, cto32 and cto64, using the same method than ctlzxx /
> > cloxx implementations
> > - add ctpop8, ctpop16, ctpop32 and ctpop64, using the Sparc target
> > implementation method
> >   ctpop8 is used by the PowerPC target, I added ctpop16 for consistency
> > - change the Alpha and the PowerPC targets to use those helpers
> 
> I did commit the ctz, cto and ctpop helpers. I have a remaining patch
> that contains the changes for mulu64 / muls64 and optimize clz64 and
> clo64, avoiding 64 bits values manipulation, which may help when running
> on a 32 bits host.
> 
> Please comment.

I like it.


Thiemo