From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImUcT-0003Ha-L6 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 09:25:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImUcS-0003GH-Di for qemu-devel@nongnu.org; Mon, 29 Oct 2007 09:25:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImUcS-0003G8-5X for qemu-devel@nongnu.org; Mon, 29 Oct 2007 09:25:28 -0400 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImUcR-0002Px-Q2 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 09:25:27 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id l9TDPQei023393 for ; Mon, 29 Oct 2007 09:25:26 -0400 Received: from file.surrey.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l9TDPQsw012886 for ; Mon, 29 Oct 2007 09:25:26 -0400 Received: (from berrange@localhost) by file.surrey.redhat.com (8.13.1/8.13.1/Submit) id l9TDPPgC009160 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 13:25:25 GMT Date: Mon, 29 Oct 2007 13:25:25 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom Message-ID: <20071029132525.GA7128@redhat.com> References: <11936114152690-git-send-email-Laurent.Vivier@bull.net> <11936114153499-git-send-email-Laurent.Vivier@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11936114153499-git-send-email-Laurent.Vivier@bull.net> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote: > From: Laurent Vivier > > This patch allows to define where is connected the CDROM device (bus, > unit). > It extends the "-cdrom" syntax to add these paramaters: > > -cdrom file[,if=type][,bus=n][,unit=m] > > where "type" defines the interface (by default, "ide") > "n" defines the bus number (by default 1) > "m" defines the unit number (by default 0) Having a separately named arg just for CDROMs was always rather odd/unhelpful. I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unchanged and use the -disk for setting up all types of disks, floppys, cdroms, etc. It would just require one extra field for the -disk arg: -disk file[,if=type][,bus=n][,unit=m][,mode=mode] where "type" defines the interface. [ide,scsi,fd] (by default, "ide") "n" defines the bus number (by default 1) "m" defines the unit number (by default 0) "mode" defines one of [disk,floppy,cdrom] If we ever up able to emulate other types of SCSI / IDE devices (tape drives, cdr, dvd perhaps) then the 'mode' can easily be extended to cover them. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|