From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ImVhI-0001jc-5C
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:34:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ImVhC-0001hB-To
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:34:31 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ImVhC-0001h4-Oc
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:34:26 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1ImVhC-0004Zk-BH
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:34:26 -0400
Date: Mon, 29 Oct 2007 14:34:21 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is
	connected the cdrom
Message-ID: <20071029143421.GD18384@networkno.de>
References: <11936114152690-git-send-email-Laurent.Vivier@bull.net>
	<11936114153499-git-send-email-Laurent.Vivier@bull.net>
	<20071029132525.GA7128@redhat.com> <4725E7ED.6050305@bull.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <4725E7ED.6050305@bull.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: qemu-devel@nongnu.org

Laurent Vivier wrote:
> Daniel P. Berrange a =E9crit :
>> On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote:
>>> From: Laurent Vivier <vivierl@frecb07144.(none)>
>>>
>>> This patch allows to define where is connected the CDROM device (bus,
>>> unit).
>>> It extends the "-cdrom" syntax to add these paramaters:
>>>
>>>      -cdrom file[,if=3Dtype][,bus=3Dn][,unit=3Dm]
>>>
>>>  where "type" defines the interface (by default, "ide")
>>>        "n" defines the bus number (by default 1)
>>>        "m" defines the unit number (by default 0)
>> Having a separately named arg just for CDROMs was always rather=20
>> odd/unhelpful.
>> I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc=20
>> unchanged
>> and use the -disk for setting up all types of disks, floppys, cdroms, et=
c.=20
>> It
>> would just require one extra field for the -disk arg:
>>       -disk file[,if=3Dtype][,bus=3Dn][,unit=3Dm][,mode=3Dmode]
>>    where "type" defines the interface. [ide,scsi,fd] (by default, "ide")
>>         "n" defines the bus number (by default 1)
>>         "m" defines the unit number (by default 0)
>>         "mode" defines one of [disk,floppy,cdrom]
>> If we ever up able to emulate other types of SCSI / IDE devices (tape=20
>> drives,
>> cdr, dvd perhaps) then the 'mode' can easily be extended to cover them.
>
> I agree with that. And if everyone agrees I can modify patches to do=20
> that...

Please go ahead. :-)


Thiemo